Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set crossFrame as false by default #218

Closed
yevhenii-username opened this issue May 27, 2022 · 3 comments
Closed

Set crossFrame as false by default #218

yevhenii-username opened this issue May 27, 2022 · 3 comments
Labels

Comments

@yevhenii-username
Copy link

yevhenii-username commented May 27, 2022

crossFrame the default should be false, as it's surprising this behavior is even possible in the browser.
You can spend a lot of time trying find issues which related to lost focus on inputs in main windows.
And after a few days you find that some of dependencies of the project which run inside the iframe use react-focus-lock whithout crossFrame param (just because it's
non-obvious)

#104 (comment) comment

@theKashey
Copy link
Owner

I cannot change default value of this properly without changing major version as it could be a breaking change.

Instead I would propose the "actual fix" for the problem and make this behavior observable, obvious and no longer surprising.

@yevhenii-username
Copy link
Author

yevhenii-username commented May 29, 2022

But in my case, it not working properly. As you can see, all things inside the iframe (right side) working properly, but if you go to the main window there is issues with input focus, also all hovers working

Screen.Recording.2022-05-27.at.19.33.05.mov

This modal inside FocusLock componen
Screenshot 2022-05-29 at 10 17 06

@stale
Copy link

stale bot commented Apr 30, 2023

This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far.

@stale stale bot added the state label Apr 30, 2023
@stale stale bot closed this as completed May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants