-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set crossFrame as false by default #218
Comments
I cannot change default value of this properly without changing major version as it could be a breaking change. Instead I would propose the "actual fix" for the problem and make this behavior observable, obvious and no longer surprising. |
This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far. |
crossFrame the default should be false, as it's surprising this behavior is even possible in the browser.
You can spend a lot of time trying find issues which related to lost focus on inputs in main windows.
And after a few days you find that some of dependencies of the project which run inside the iframe use react-focus-lock whithout crossFrame param (just because it's
non-obvious)
#104 (comment) comment
The text was updated successfully, but these errors were encountered: