Skip to content
This repository has been archived by the owner on Oct 14, 2019. It is now read-only.

Ensure database operations are completed and successful before replying to requests #129

Open
rickles42 opened this issue Jun 21, 2018 · 3 comments
Labels
bug Something isn't working to do

Comments

@rickles42
Copy link
Contributor

Right now some of the request handlers reply to the user before all the relevant database operations have occurred. If a database operation fails, or if some exception is raised after replying that causes the session to roll back, that would mean we've told the user something happened when in reality it did not.

@rickles42 rickles42 added the bug Something isn't working label Jun 21, 2018
@thecsw thecsw added the to do label Nov 16, 2018
@Keanu73
Copy link
Contributor

Keanu73 commented Jun 7, 2019

Has this been fixed?

@thecsw
Copy link
Owner

thecsw commented Jun 7, 2019

Kind of. Not as we would like it to be. So, if fail happens, we rollback

@Keanu73
Copy link
Contributor

Keanu73 commented Jun 12, 2019

In the Go rewrite, GORM will do all the error handling for us

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working to do
Projects
None yet
Development

No branches or pull requests

3 participants