Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix creating modulemd filters #1614

Merged
merged 1 commit into from
May 31, 2023
Merged

fix creating modulemd filters #1614

merged 1 commit into from
May 31, 2023

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented May 31, 2023

Fixes: #1608

@evgeni evgeni changed the title add test for creating modulemd filters fix creating modulemd filters May 31, 2023
ehelms
ehelms approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the test failures expected?

@evgeni
Copy link
Member Author

evgeni commented May 31, 2023

Are the test failures expected?

ish, they were unrelated, but i've rebased on fixed develop to see if they are gone :)

@evgeni evgeni merged commit 1727958 into theforeman:develop May 31, 2023
@evgeni evgeni deleted the filtermod branch May 31, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError: 'content_filter_rule_modulemd_spec' - missing rule spec
2 participants
@evgeni @ehelms