Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marking the execution as no_log when root_pass is defined #1700

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Marking the execution as no_log when root_pass is defined #1700

merged 1 commit into from
Jan 9, 2024

Conversation

sscheib
Copy link
Contributor

@sscheib sscheib commented Jan 9, 2024

Marking the execution as no_log when root_pass is defined in the iteration of foreman_hostgroups.
This prevents values defined via root_pass from being shown during execution.

Fixes #1699

@evgeni evgeni merged commit 0d055af into theforeman:develop Jan 9, 2024
23 checks passed
@sscheib sscheib deleted the ft-fix_hostgroup_root_pass_exposure branch January 9, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Role theforeman.foreman.hostgroups shows passwords during execution when defined via root_pass
2 participants
@sscheib @evgeni