Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing labels fails due to wrong URL parsing #20

Closed
dLobatog opened this issue Feb 7, 2015 · 0 comments
Closed

Replacing labels fails due to wrong URL parsing #20

dLobatog opened this issue Feb 7, 2015 · 0 comments

Comments

@dLobatog
Copy link
Member

dLobatog commented Feb 7, 2015

Currently octokit.rb uses CGI.escape for parsing the label. This makes strings like Waiting on contributor look like Waiting+on+contributor. The Github API v3 will not recognize such strings, as the spec (rightly so) says spaces should be encoded as %20, not +.

This renders the bot unable to replace the labels, and I rely on them to know at first glance which Pull Requests need a review. We cannot go back to < 3.0 Octokit because other prprocessor features depend on it.

I'm thinking of a possible patch, perhaps using ERB::Util.url_encode but it's going to be tricky as before sending the API request, Octokit tries to clean up the URL using URI::Parser, and that would convert every %20 into %2520.

Any ideas to get some hotfix in prprocessor appreciated. Aside from the obvious of adding hyphens or dashes to the label names 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant