Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systemd dependency missing #704

Closed
amateo opened this issue Jul 31, 2019 · 5 comments · Fixed by #710
Closed

Systemd dependency missing #704

amateo opened this issue Jul 31, 2019 · 5 comments · Fixed by #710

Comments

@amateo
Copy link
Contributor

amateo commented Jul 31, 2019

I'm trying to install puppetsever with your module, but I get:

Error: Evaluation Error: Error while evaluating a Resource Statement, Unknown resource type: 'systemd::dropin_file' (file: /home/amateo_adm/puppetcode/puppet/manifests/server/puppetserver.pp, line: 196, column: 7) on node mus50.um.es

I have to manually install module camptocamp/systemd to fix it, so I guess it could be listed in requirements.

@ekohl
Copy link
Member

ekohl commented Jul 31, 2019

@walkamongus
Copy link

I just wanted to question this dependency as I feel it potentially reaches too far outside of module scope. Should an application-specific module for puppet require a specific module for managing something as fundamental/system-wide as systemd? I certainly see that it makes things easier but it also means if this module is used, you can't use any other systemd module.

@jay7x
Copy link

jay7x commented Sep 16, 2019

Just curious why puppet::agent::service::systemd is creating systemd unit & timer files directly (not using systemd module) then?

@ekohl
Copy link
Member

ekohl commented Sep 16, 2019

@jay7x that's a good point. The explanation is mostly historical. We added those when the systemd module wasn't as complete as today. It is probably a good idea to rewrite that to use the module as well. That might also be a good reason to make it a hard dependency since then there's functionality in both the agent and the server that uses it.

@ekohl
Copy link
Member

ekohl commented Oct 23, 2019

#710 should fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants