Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appending values with puppet::config::entry is broken #759

Closed
dnlsng opened this issue Aug 14, 2020 · 2 comments · Fixed by #782
Closed

Appending values with puppet::config::entry is broken #759

dnlsng opened this issue Aug 14, 2020 · 2 comments · Fixed by #782

Comments

@dnlsng
Copy link

dnlsng commented Aug 14, 2020

This commit, e87d8f2, breaks the ability to add multiple puppet::config::entry resources for the same key. By setting ensure_newline to true on the concat resource, a new line is added at the end of every fragment which removes the ability to append values. The appended values appear on the next line which results in a puppet config file which is not valid.

One way to resolve this would be to revert this commit and then add a concat fragment at the end of the file with just a single new line character.

@ekohl
Copy link
Member

ekohl commented Aug 28, 2020

This was indeed mentioned @ #707 (comment) but I never got around to reverting it.

A patch would be very welcome.

@dnlsng
Copy link
Author

dnlsng commented Sep 10, 2020

Sorry, I've been busy and only just had a chance to get around to a patch.

@ekohl ekohl linked a pull request Sep 15, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants