-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glimmer2 Compatibility #14
Comments
I've got a spike on this, though I'm unsure how I feel about it 😝 |
I'm just going to drop this here. Please don't tell any Ember core team members about it. https://ember-twiddle.com/16243ed7e17b2cc5bb57b4322aa1ed71?openFiles=templates.application.hbs%2C |
Haha, indeed I am aware 😉 It still has the super unexpected issues of not rendering the block if you happen to use something that evaluates to falsey ( Honestly, I am pretty excited about the newer inline form. I want to continue experimenting then convince @cowboyd to write an RFC to make it part of Ember... 😈 |
FWIW, I have a pretty gnarly spike on fixing this in canary/alpha builds with Glimmer but it is pretty annoying. I tried to do some cleanup in a recent Ember PR to make this a bit easier/nicer. |
Ah yes, not rendering the block when the first value is falsey definitely makes that a non-starter. |
Ember let test suite should pass against glimmer enabled ember, but falls over.
https://travis-ci.org/thefrontside/ember-let/jobs/156027764
The text was updated successfully, but these errors were encountered: