Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings on setCustomProps and getResources #25

Open
Derpalus opened this issue Mar 11, 2019 · 4 comments
Open

Deprecation warnings on setCustomProps and getResources #25

Derpalus opened this issue Mar 11, 2019 · 4 comments

Comments

@Derpalus
Copy link

Hello!

I'm getting deprecation warnings on setCustomProps and getResources in OkHttpSardine.java. Apparently, the functions they override have been deprecated in Sardine.

@guillaume-tgl
Copy link
Contributor

Yes, as mentioned in the comments, it's better to use list instead of getResources and patch instead of setCustomProps.

@Derpalus
Copy link
Author

Of course, however, I was thinking about Android Studio Lint complaining about deprecation and even failing release compilations if these warnings remain (even if not actually using the functions). A simple way of fixing them is to just mark the functions in question as deprecated in turn.

@guillaume-tgl
Copy link
Contributor

Ok, I understand. This comes from the legacy Sardine library so I've never really thought about it. I'm not against removing these deprecated methods, both in the interface and in the class, or simply annotate them as deprecated. Do you want to make a PR?

@Derpalus
Copy link
Author

Well, I'm currently just using this project in an app, I don't have it checked out or am particularly good at using GitHub, so perhaps it's easier if you do it so it gets done correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants