Use inversify to build the example electron app #4869

paul-marechal · 2019-04-10T16:25:33Z

Every new logic that should happen in the Electron main process
currently has to be written inside the generators. This is difficult to
extend.

This commit refactorize the electron-main.js script to use inversify
in order to customize the logic happening when launching an electron
application.

Signed-off-by: Paul Maréchal [email protected]

This should begin to align Electron application development with the frontend/backend extensions.

dev-packages/application-manager/src/generator/frontend-generator.ts

thegecko

Runs locally and LGTM. Probably needs another pair of eyes on it as I'm not too learned in this area of Theia :)

akosyakov · 2019-04-11T06:03:45Z

I will have a look later today, had to fix theia-apps next images first, second time this week 🙈

akosyakov · 2019-04-11T14:17:57Z

Wrapping communications between main and renderer processes into JSON-RPC services would be cool next step. Then we will have aligned arch for all processes.

paul-marechal · 2019-04-12T21:29:31Z

Wrapping communications between main and renderer processes into JSON-RPC services would be cool next step. Then we will have aligned arch for all processes.

Do you want me to set that up in this PR or would it be a follow up?

packages/core/src/electron-main/electron-main-application.ts

akosyakov · 2019-04-13T08:10:00Z

@marechal-p separately

packages/core/src/electron-main/electron-storage-service.ts

packages/core/src/electron-main/electron-native-keymap-service.ts

yarn.lock

paul-marechal · 2019-04-24T15:04:14Z

@akosyakov the PR is already approved but since you had comment I am waiting for yours.

akosyakov · 2019-04-25T05:46:23Z

@kittaakos Could you have a look that control flow is still good for bundled electron apps?

packages/core/package.json

packages/core/src/electron-main/electron-storage-service.ts

akosyakov · 2019-04-25T05:55:39Z

@marechal-p sorry i would need more time with this code which i don't have now (support of VS Code extension is more important). Looking at the code i don't think contribution points are properly designed. Usually we have an app which does start up and then lifecycle contributions allow to participate, in this PR it seems that lifecycle contribution does the startup like creating windows, making sure that state is stored. It should not be like that.

kittaakos · 2019-04-25T05:56:50Z

@kittaakos Could you have a look that control flow is still good for bundled electron apps?

I could, but you'll have to wait till next week though.

paul-marechal · 2019-04-25T17:12:19Z

sorry i would need more time with this code which i don't have now (support of VS Code extension is more important).

Indeed, I just didn't know who else to ping that would like to have a look at that, I know you made the setup for frontend/backend so I figured you'd have comments.

Looking at the code i don't think contribution points are properly designed.

Ah yes, I wasn't so sure how to handle it. My original idea was to allow clients to almost entirely define the way they want to handle the lifecycle for the electron application, without imposing ours.

I can see how to improve that.

I could, but you'll have to wait till next week though.

Perfect, thank you :)

paul-marechal · 2019-04-29T13:50:52Z

@kittaakos I am not 100% convinced that the lifecycle management is perfect, but maybe you have some advices/opinions already?

kittaakos

Wow, the startup is way faster than before. 👍

I have added a few remarks here and there; I am happy to try it again if you have any updates/changes. If you have any questions, or you disagree with any of my comments, please let me know.

dev-packages/application-manager/src/generator/frontend-generator.ts

packages/core/src/electron-main/electron-main-application.ts

akosyakov · 2019-05-15T05:14:04Z

@kittaakos could you finish the review please? I won't have time to have a look and don't want to stay in the way much.

@marechal-p let's go with whatever you have now and refactor it later then

kittaakos · 2019-05-15T06:41:25Z

@kittaakos could you finish the review please?

👍 Sure.

vince-fugnitto · 2019-07-25T15:02:30Z

@marechal-p do you still plan on continuing your work on the PR?

I think it's really interesting and will also make it a lot easier for devs in the future to update the Electron part of the application while also improving startup time :)

paul-marechal · 2019-07-25T15:18:33Z

I mean, I was pretty much done. Unless someone sees something missing.

I can rebase.

Every new logic that should happen in the Electron main process currently has to be written inside the generators. This is difficult to extend. This commit refactorize the `electron-main.js` script to use inversify in order to customize the logic happening when launching an electron application. Signed-off-by: Paul Maréchal <[email protected]>

paul-marechal · 2019-07-25T15:55:51Z

packages/core/src/electron-main/electron-main-application.ts

+            event.preventDefault();
+            let preventStop = false;
+            // Ask all opened windows whether they want to prevent the \`close\` event or not.
+            for (const window of electron.BrowserWindow.getAllWindows()) {


I rebased using gitpod, but I think I should test that locally, really don't know where to move this code right now.

paul-marechal · 2019-10-31T20:05:44Z

The use case was raised internally to be able to customize the electron main process.

According to @akosyakov earlier comments, I am rewriting a new PR which will connect electron-renderer processes and the electron-main process using our JsonRpcProxies.

Changes should be better than the current PR, so I will close this and open a new one when ready.

paul-marechal requested review from thegecko, kittaakos and akosyakov April 10, 2019 16:25

paul-marechal added electron issues related to the electron target quality issues related to code and application quality labels Apr 10, 2019

thegecko requested changes Apr 10, 2019

View reviewed changes

dev-packages/application-manager/src/generator/frontend-generator.ts Outdated Show resolved Hide resolved

dev-packages/application-manager/src/generator/frontend-generator.ts Outdated Show resolved Hide resolved

paul-marechal force-pushed the mp/electron-inversified branch from a18fd67 to d976534 Compare April 10, 2019 19:44

paul-marechal requested a review from thegecko April 10, 2019 19:45

thegecko approved these changes Apr 10, 2019

View reviewed changes

akosyakov mentioned this pull request Apr 11, 2019

[electron] fetch native layout in main process #4886

Open

akosyakov reviewed Apr 13, 2019

View reviewed changes

packages/core/src/electron-main/electron-main-application.ts Outdated Show resolved Hide resolved

akosyakov reviewed Apr 13, 2019

View reviewed changes

packages/core/src/electron-main/electron-main-application.ts Outdated Show resolved Hide resolved

paul-marechal force-pushed the mp/electron-inversified branch from d976534 to cfaed14 Compare April 15, 2019 11:37

paul-marechal commented Apr 15, 2019

View reviewed changes

packages/core/src/electron-main/electron-storage-service.ts Outdated Show resolved Hide resolved

packages/core/src/electron-main/electron-native-keymap-service.ts Outdated Show resolved Hide resolved

paul-marechal commented Apr 15, 2019

View reviewed changes

yarn.lock Show resolved Hide resolved

kittaakos removed their request for review April 16, 2019 11:18

paul-marechal force-pushed the mp/electron-inversified branch from cfaed14 to c6347b2 Compare April 24, 2019 15:01

akosyakov reviewed Apr 25, 2019

View reviewed changes

packages/core/package.json Outdated Show resolved Hide resolved

akosyakov reviewed Apr 25, 2019

View reviewed changes

packages/core/src/electron-main/electron-storage-service.ts Outdated Show resolved Hide resolved

akosyakov reviewed Apr 25, 2019

View reviewed changes

packages/core/src/electron-main/electron-storage-service.ts Outdated Show resolved Hide resolved

paul-marechal force-pushed the mp/electron-inversified branch from fac8de5 to 96215a6 Compare April 26, 2019 22:25

paul-marechal force-pushed the mp/electron-inversified branch 2 times, most recently from 5a1704c to 2048a26 Compare April 29, 2019 13:49

paul-marechal force-pushed the mp/electron-inversified branch from 2048a26 to ec77411 Compare April 29, 2019 13:52

kittaakos mentioned this pull request May 14, 2019

[electron] unable to quit electron instance due to preference #4800

Closed

kittaakos reviewed May 14, 2019

View reviewed changes

paul-marechal force-pushed the mp/electron-inversified branch from ec77411 to 9f8c716 Compare May 15, 2019 13:21

kittaakos mentioned this pull request May 28, 2019

[electron] improve startup performance #5284

Closed

paul-marechal force-pushed the mp/electron-inversified branch from 9f8c716 to b0759f9 Compare July 25, 2019 15:53

paul-marechal commented Jul 25, 2019

View reviewed changes

paul-marechal closed this Oct 31, 2019

vince-fugnitto mentioned this pull request Feb 4, 2020

[electron] Electron not showing the active editor in the window title as in VScode #7076

Closed

owlJaeger mentioned this pull request May 12, 2020

Added ability to change windowOptions & it's defaults. Moved disallowReloadKeybinding inside electron subsection #7803

Merged

1 task

paul-marechal deleted the mp/electron-inversified branch February 25, 2021 22:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use inversify to build the example electron app #4869

Use inversify to build the example electron app #4869

paul-marechal commented Apr 10, 2019

thegecko left a comment

akosyakov commented Apr 11, 2019

akosyakov commented Apr 11, 2019

paul-marechal commented Apr 12, 2019 •

edited

Loading

akosyakov commented Apr 13, 2019

paul-marechal commented Apr 24, 2019

akosyakov commented Apr 25, 2019

akosyakov commented Apr 25, 2019

kittaakos commented Apr 25, 2019

paul-marechal commented Apr 25, 2019

paul-marechal commented Apr 29, 2019

kittaakos left a comment

akosyakov commented May 15, 2019

kittaakos commented May 15, 2019

vince-fugnitto commented Jul 25, 2019

paul-marechal commented Jul 25, 2019

paul-marechal Jul 25, 2019

paul-marechal commented Oct 31, 2019

Use inversify to build the example electron app #4869

Use inversify to build the example electron app #4869

Conversation

paul-marechal commented Apr 10, 2019

thegecko left a comment

Choose a reason for hiding this comment

akosyakov commented Apr 11, 2019

akosyakov commented Apr 11, 2019

paul-marechal commented Apr 12, 2019 • edited Loading

akosyakov commented Apr 13, 2019

paul-marechal commented Apr 24, 2019

akosyakov commented Apr 25, 2019

akosyakov commented Apr 25, 2019

kittaakos commented Apr 25, 2019

paul-marechal commented Apr 25, 2019

paul-marechal commented Apr 29, 2019

kittaakos left a comment

Choose a reason for hiding this comment

akosyakov commented May 15, 2019

kittaakos commented May 15, 2019

vince-fugnitto commented Jul 25, 2019

paul-marechal commented Jul 25, 2019

paul-marechal Jul 25, 2019

Choose a reason for hiding this comment

paul-marechal commented Oct 31, 2019

paul-marechal commented Apr 12, 2019 •

edited

Loading