Fix plugin loading to cope with modules that have immutable exports

[sstone1]

Fixes #5514

Some node modules, such as ansi-styles, define the exports property in an immutable manner: https://github.com/chalk/ansi-styles/blob/master/index.js#L159

Because the exports property has no setter, it throws an error when we try to overwrite it. We can just delete it instead.

Also, you cannot reload native modules - an error is thrown when you attempt to do so:

Error: Failed to load /Users/sstone1/git/blockchain-vscode-extension/client/ibm-blockchain-platform-1.0.3/extension/node_modules/grpc/src/node/extension_binary/node-v64-darwin-x64-unknown/grpc_node.node. Module did not self-register.

... so I've also fixed the code to skip doing anything with native modules (which have an ID that ends with .node).

[akosyakov]

@benoitf @evidolob please review when you have a chance

[benoitf]

thanks @sstone1 👍

[sstone1]

@evidolob please could you review this PR?

[akosyakov]

@sstone1 How can one verify it? Do you have an extension to test?

[akosyakov]

@evidolob it would be nice if we get contributors do proper reviews (i.e. that everything from #5616 is covered and good review comments are provided) in addition of opening new PRs. Otherwise we are getting a lot of contributions but cannot really accept them.

[sstone1]

@akosyakov I've tested it locally with our IBM Blockchain Platform extension - here's the Che plugin configuration I've been using:

https://gist.githubusercontent.com/sstone1/2882d58638838914f3a4cabf67b50df1/raw/1c1e60d3299fffdb785b586afc530054cf5b024a/meta.yaml
https://github.com/sstone1/che-plugin-registry/releases/download/0.0.1/ibm-blockchain-platform-1.0.3.vsix

Our extension pulls in modules with immutable exports (ansi-styles) and native modules (grpc).

The behaviour I observed before the fix is that the extension loads once inside Che, and then when you F5 - it will not load again.

FYI - don't use the extension version from the VSCode marketplace - it won't work inside Che.

[akosyakov]

thanks for the fast response, I've verified with installing blockchain and go vscode extensions that they both can be loaded without regressions.

[akosyakov]

Although i found #5626