Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-5620: Fixed the toolbar item comparator. #5624

Merged
merged 1 commit into from
Jul 2, 2019
Merged

GH-5620: Fixed the toolbar item comparator. #5624

merged 1 commit into from
Jul 2, 2019

Conversation

kittaakos
Copy link
Contributor

Closes #5620.

Signed-off-by: Akos Kitta [email protected]

@kittaakos kittaakos requested a review from vince-fugnitto July 2, 2019 14:24
vince-fugnitto
vince-fugnitto approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great!
Thank you for also adding the additional unit tests for it :)

I tried both the search-in-workspace and git widgets on chrome and firefox and consistently got the correct results on both.

@kittaakos kittaakos merged commit fd50a4b into master Jul 2, 2019
@kittaakos kittaakos deleted the GH-5620 branch July 2, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[scm] the order of icon in scm is different in Chrom and Firefox
2 participants
@kittaakos @vince-fugnitto