Fix clumsy suggest dropdown from form inputs #5990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4074 - fixes annoying issue with the search input present in the `search-in-workspace` widget which displays a browser specific auto-suggestion based on previous form history. The suggestion is now disabled using the `autoComplete: 'off' prop. - fixes a similar issue with the `keyboard shortcuts` widget as well. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
added
keybindings
|
Tested in example browser. I confirm the suggest dropdown does not show up any more. |
elaihau
approved these changes
Aug 20, 2019
svenefftinge
approved these changes
Aug 20, 2019
|
Thank you @elaihau @svenefftinge for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #4074
search-in-workspacewidget which displays a browser specificauto-suggestion based on previous form history. The suggestion
is now disabled using the `autoComplete: 'off' prop.
keyboard shortcutswidget as well.How to test
Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto [email protected]