Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internalize the assertion API #1138

Closed
jason0x43 opened this issue Apr 14, 2020 · 1 comment
Closed

Internalize the assertion API #1138

jason0x43 opened this issue Apr 14, 2020 · 1 comment
Labels
effort-low Should be pretty quick enhancement A new or improved feature priority-high Most important

Comments

@jason0x43
Copy link
Member

Export chai's assert and expect on the default intern export, allowing for:

import { assert } from 'intern';
assert.isOk(foo);

// or

import intern from 'intern';
intern.assert.isOk(foo);

// or, using the global, just

intern.assert.isOk(foo);

See #1041 for discussion
@jason0x43 jason0x43 added enhancement A new or improved feature effort-low Should be pretty quick priority-high Most important labels Apr 14, 2020
@jason0x43
Copy link
Member Author

Closing as duplicate of #1120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort-low Should be pretty quick enhancement A new or improved feature priority-high Most important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jason0x43