Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Lounge Awakens #2

Merged
merged 14 commits into from
Feb 10, 2016
Merged

The Lounge Awakens #2

merged 14 commits into from
Feb 10, 2016

Conversation

astorije
Copy link
Member

No description provided.

astorije added a commit that referenced this pull request Feb 10, 2016
@astorije astorije merged commit 56c83c0 into master Feb 10, 2016
@astorije astorije deleted the astorije/switch-to-the-lounge branch February 10, 2016 07:48
@xPaw
Copy link
Member

xPaw commented Feb 10, 2016

Why did you remove .travis.yml?

@astorije
Copy link
Member Author

@xPaw, commit message is:

Remove Travis CI configuration for now …
Pretty much the entire file is invalid now and Travis CI has not been enabled here yet.

Out of the previous file:

  • Node versions is not up-to-date anymore (I wanted to remove 0.10 but maybe not a good idea since Jessie is running it)
  • sudo: false is not necessary anymore
  • The deploy section is now invalid

On top of that, since we had only 1 test (lol), Travis CI is merely used to deploy on npm. I will re-add an updated Travis file before the end of the week and before the npm package gets published, now I was merely removing all references to "shout" itself.

Hope that helps :)

@xPaw
Copy link
Member

xPaw commented Feb 10, 2016

On top of that, since we had only 1 test (lol), Travis CI is merely used to deploy on npm.

It also ran eslint.

@astorije
Copy link
Member Author

Correct, forgot about that. But don't worry, it's a temporary removal until I enable Travis CI.

@astorije astorije self-assigned this Feb 13, 2016
@astorije astorije added this to the 1.0.0 milestone Apr 1, 2017
MaxLeiter pushed a commit that referenced this pull request Feb 9, 2021
brunnre8 pushed a commit to brunnre8/thelounge that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants