Disallow /query on non-nicks #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
Type: Bug
|
👎 I've tackled this in 87d0f14, and I want that branch merged asap. |
|
@xPaw, I would like to release ASAP and I decently can't with the bug introduced by #218. Would you mind reconsidering please? Also, the framework-irc PR is clearly not for right now (for example, we can't ship before Thanks! |
It is supported. |
My bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quickfix of #218 until
framework-ircprobably makes us solve that differently anyway.At least it avoids going into a weird state that cannot be easily recovered.