Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command-line/add,reset: reword password prompt #230

Merged
merged 1 commit into from
Apr 9, 2016

Conversation

williamboman
Copy link
Member

This makes the password prompts not look like a root access password prompt.

@maxpoulin64 maxpoulin64 added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Mar 31, 2016
@AlMcKinlay
Copy link
Member

Interesting. Should we make it even more obvious by saying something like "Enter The Lounge password"?

@AlMcKinlay AlMcKinlay self-assigned this Apr 2, 2016
@williamboman
Copy link
Member Author

Interesting. Should we make it even more obvious by saying something like "Enter The Lounge password"?

I think The Lounge password is a bit dubious, something like Enter new user's password: perhaps?

@maxpoulin64
Copy link
Member

I'm really not a fan of super long prompts. Maybe New password: would be enough to clear the confusion with the root password? Or maybe we could go the sudo way, [sudo] Password for max-p: and write something like [lounge] New password:?

In general I think it shouldn't be our problem that the user can confuse prompts from other programs they use with The Lounge. If you use su -c you should be aware that su has a Password: prompt before ours.

@williamboman
Copy link
Member Author

and write something like [lounge] New password:

👍, I like it!

@maxpoulin64
Copy link
Member

Fine by me 👍

@AlMcKinlay
Copy link
Member

Yes, I like this. However, as @astorije would probably say, it should probably be [thelounge] as that's our shortened version of the name.

This makes the password prompts not look like a root access password prompt.
@williamboman williamboman force-pushed the fix/password-prompt branch from f2cd702 to 8293497 Compare April 3, 2016 18:47
@astorije astorije merged commit 49a62c4 into thelounge:master Apr 9, 2016
@williamboman williamboman deleted the fix/password-prompt branch April 15, 2016 10:38
@astorije astorije added this to the 1.5.0 milestone Sep 28, 2016
@AlMcKinlay AlMcKinlay removed their assignment Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants