Implement WEBIRC #240
Implement WEBIRC #240
Conversation
maxpoulin64
added
the
Type: Feature
maxpoulin64
force-pushed
the
webirc
branch
4 times, most recently
from
19d57dd to
93e29be
Compare
|
Code looks fine. I think this will have to wait for irc-fw to be merged. Just wondering is reverse dns really that desirable in spoofed hosts? Both kiwi and qwebirc seem to do |
|
Hmm, I'm thinking since the config file is actually Javascript, I think I'll make the |
|
Updated as irc-fw just got merged. Also added the function thing I said I'd do, so now the admins can do whatever they want, and if the admin only specifies the password then it follows the standard. |
| @@ -103,7 +111,7 @@ function init(socket, client, token) { | |||
| socket.on( | |||
| "conn", | |||
| function(data) { | |||
| client.connect(data); | |||
| client.connect(data, false); | |||
There was a problem hiding this comment.
What if instead of passing in trusted boolean, we filtered it here?
There was a problem hiding this comment.
That's a great idea, I'll change that!
|
👍 |
| }; | ||
| } | ||
| } else { | ||
| console.warn("Cannot find a valid WEBIRC configuration for " + nick |
There was a problem hiding this comment.
Change to log.warn which is now in master.
maxpoulin64
force-pushed
the
webirc
branch
2 times, most recently
from
d1c8e1c to
b9d6823
Compare
| @@ -79,6 +79,9 @@ function Client(manager, name, config) { | |||
| log.info("User '" + name + "' loaded"); | |||
| } | |||
|
|
|||
| Client.prototype.ip = null; | |||
| Client.prototype.host = null; | |||
|
|
|||
|
@maxpoulin64 and I went through the code together offline, 👏 for the feature! |
|
👍 and merging, great job on this, @maxpoulin64! |
|
This has been a LONG time coming. I've been waiting for Shout to implement the web IRC protocol for quite some time. Is this working out of the box? (Waiting in excitement.) |
|
@spencerthayer: what do you mean by out of the box? You still need to configure it to put your webirc password for each network, but yes it otherwise just works. |
Implement WEBIRC
|
question how do I do the format to add the webirc implement in Ive tried everything |
|
@CayneVamp-Inn, we have not documented this on the website at the moment, so your best bet is to follow the WEBIRC section of the configuration file, which lives here. As I am rewriting the docs, there is a planned guide for WEBIRC that is currently empty (code / preview), so once you figure it out, if you or anyone else wants to help us, you can come up with a first version of the guide. Good luck! |
It's finally ready!
Features:
Overall, if enabled in the
config.js, it should do what an admin would expect both in public and private mode. However, admins that wants more control can override settings as needed per user, or per user network.EDIT: An irc-framework version to make rebasing easier or in case irc-fw gets merged first.