Create a single helper function to write messages #266

xPaw · 2016-04-19T10:22:16Z

This solves a couple of issues:

Certain messages were not stored in memory, so reloading the page would not print them on the client (e.g. connection related messages)
maxHistory is always applied, not just when receiving messages in channels
Fixes Do not keep messages in memory for public users #232: Do not store messages in memory when running in public mode
Single consistent function increases readability (and less boilerplate code)

maxpoulin64 · 2016-04-19T20:49:06Z

src/models/chan.js

@@ -9,6 +10,7 @@ Chan.Type = {
 };

 var id = 0;
+var config = Helper.getConfig();


EDIT: Fixed by moving the requires in command-line.

xPaw · 2016-04-19T21:05:11Z

src/command-line/index.js

@@ -32,6 +24,14 @@ if (!fs.existsSync(config)) {
 	console.log(config);
 }

+require("./start");


Moved these requires to fix @maxpoulin64's problem below.

maxpoulin64 · 2016-04-19T21:05:22Z

Looks fine to me 👍

astorije · 2016-04-24T00:26:53Z

Great stuff, @xPaw! 👍

Create a single helper function to write messages

6dc807e

xPaw added Type: Feature Tickets that describe a desired feature or PRs that add them to the project. second review needed labels Apr 19, 2016

xPaw added 2 commits April 19, 2016 13:24

Create real channel object in tests

2f1eec3

Fix #232: Do not store messages in memory when running in public mode

148be76

maxpoulin64 reviewed Apr 19, 2016
View reviewed changes

Fix loading config before HOME variable is set

f4ac2aa

xPaw reviewed Apr 19, 2016
View reviewed changes

astorije merged commit 8c41975 into master Apr 24, 2016

astorije deleted the xpaw/server-log branch April 24, 2016 00:27

astorije assigned maxpoulin64 Apr 27, 2016

astorije removed the second review needed label Apr 27, 2016

astorije added this to the ★ Next Release milestone May 15, 2016

Provide feedback