Fix missing colors in action messages #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
Type: Bug
astorije
force-pushed
the
astorije/colored-nicknames
branch
from
058dde4 to
9df0195
Compare
This was referenced May 10, 2016
astorije
force-pushed
the
astorije/colored-nicknames
branch
from
9df0195 to
aad757e
Compare
|
Looks all good to me. 👍 I think we were waiting to have a better way to deal with colors before we did this, but since that can take a while still I vote to merge this and deal with the colors as a whole separately. |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…names Fix missing colors in action messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was heavily inspired by erming/shout#664 (and discussion on erming/shout#663) so kudos and credits go to @bews! \o/
This is also the last missing piece of #31. I don't know why I didn't fix that earlier, really...
A few screenshots to illustrate this:
(We can't really see on this last one but `astorije` has a slightly different color.)