CI tool for Windows builds #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
Type: Feature
|
Seriously, Travis CI has had time to build 4 versions that AppVeyor hasn't even started one. Definitely only one version in its conf or we'll never wait for the build to finish before merging :-) |
|
Looks good to me, not always easy to get a Winblows handy to test on 👍 |
| test_script: | ||
| - node --version | ||
| - npm --version | ||
| - npm run test:mocha |
There was a problem hiding this comment.
Change these three npm run to just npm run test
There was a problem hiding this comment.
Change these three npm run to just npm run test
Also, you can just do "npm test" as that's a link in npm to "npm run test"
There was a problem hiding this comment.
True, we lose reports if one fails (as Travis CI does), but the whole point of this is to make sure npm install and npm test do not break for Windows...
Done in c886657.
astorije
force-pushed
the
astorije/appveyor
branch
from
d402b0d to
55c483b
Compare
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
CI tool for Windows builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History has shown that we have broke our build/test environment on Windows before, see #309.
This is just a smoke test to make sure we don't do this again. For example, things like #361 need that kind of things, otherwise we'll always have to ask "can someone test on Windows please?" :-)
Regarding Node version, I went for latest LTS. I know @maxpoulin64 is in favor of specifying latest. I don't have a preference, I'll go with whatever you guys want. Any of them is still better than none!
Note that AppVeyor does not parallelize and is rather super slow, so we should stick to one.
Also, you'll notice badge says
astorije/lounge. That's because stupid AppVeyor doesn't reflect GitHub organizations, doh. If that's a huge deal for you, I'll find a way (like creating a secondary account, but what a pain), otherwise I think it's good enough for our needs.