Update lodash #38
Update lodash #38
Conversation
|
Let's have 2 👍 on this one, it's quite a dangerous PR and needs to be tested fairly well :-) |
astorije
added
the
Type: Feature
|
Can @JocelynDelalande, @YaManicKill or @wizardfrag self-assign this one please? :-) |
|
As I'm not myself doogfooding |
| @@ -135,4 +135,3 @@ ClientManager.prototype.autoload = function(/* sockets */) { | |||
| }); | |||
| }, 1000); | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
Was that intentional? We should always keep an EOF line to keep git and other tools happy :-)
There was a problem hiding this comment.
It had two new lines at the end, my editor automatically removed the extra one.
|
(Taking ownership and first review then) So far so goo, @xPaw, but I left you a few comments inline :-) Also, just wondering, did you try something like https://github.com/lodash/lodash-migrate to migrate? Not that we should blindly rely on that, but that might give you some extra confidence that nothing was forgotten. Thanks! |
I did just now, it didn't seem to complain. |
|
👍 |
|
Cool, looks good to me. 👍 Merging. |
Hopefully I didn't miss any function changes.