Perform node version check as soon as possible #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 and merging. Good call. |
| // Doing this check as soon as possible allows us to avoid ES6 parser errors or other issues | ||
| var pkg = require("./package.json"); | ||
| if (!require("semver").satisfies(process.version, pkg.engines.node)) { | ||
| console.error("=== WARNING!"); |
There was a problem hiding this comment.
Is it worth using your logger instead, considering we control its content (and can make sure it works on Node.js < 4)?
There was a problem hiding this comment.
I wanted to, but it needed to load helper file, which needed to load config file, which requires home path processing. So it's not "as soon as possible".
astorije
added
Type: Feature
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…heck Perform node version check as soon as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to print a message before crashing when loading irc-fw