Fix webirc and 4-in-6 addresses #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpoulin64
added
Type: Bug
|
Is it guaranteed to be without any zeroes, just the ::ffff? Also verify oidentd. |
|
Yes, it will always be |
|
👍 and merging |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Fix webirc and 4-in-6 addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we fixed IPv6, now node returns us IPv4 addresses in the 6-in-4 format such as
::ffff:8.8.8.8. Not only does this conflict with servers because it starts with:, it is also not a valid argument for the webirc command.