Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token persistency across server refresh #553

Merged
merged 1 commit into from
Aug 11, 2016

Conversation

astorije
Copy link
Member

This fixes a regression introduced by LDAP support addition (#477), which forces users to re-login when the server restarts. This was originally implemented in #370.

@thisisdarshan and @lindskogen, could you proof read this PR, please? It seems to me that this was just a typo on #477 but maybe I'm wrong and this is breaking your LDAP implementation, so I value your opinion :-)

This fixes a regression introduced by LDAP support addition
(#477), which forces
users to re-login when the server restarts. This was originally
implemented in #370.
@astorije astorije added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. second review needed labels Aug 10, 2016
@astorije astorije added this to the 2.0.0 milestone Aug 10, 2016
@astorije astorije changed the title Fix token persistency across server restarts Fix token persistency across server refresh Aug 11, 2016
@maxpoulin64 maxpoulin64 merged commit 11654ff into master Aug 11, 2016
@astorije astorije deleted the astorije/fix-auth-token branch August 11, 2016 05:51
@lindskogen
Copy link
Contributor

a bit late, but LGTM :)

matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Fix token persistency across server refresh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants