Move border-radius from #main to .window elements to fix radius once and for all #572
Conversation
astorije
added
Type: Bug
astorije
force-pushed
the
astorije/fix-radiuses-again
branch
from
0bd488b to
2b2340a
Compare
…and for all #537 only fixed it on chat windows, but for some browser-specific display bug/reason not on settings, login, ...
astorije
force-pushed
the
astorije/fix-radiuses-again
branch
from
2b2340a to
f509e9f
Compare
| @@ -97,12 +97,16 @@ body { | |||
| left: 0; | |||
| bottom: 0; | |||
| width: 220px; | |||
| border-radius: 0; | |||
There was a problem hiding this comment.
All these theme overrides should actually be removed and design specific stuff moved from style.css to example.css. That would make for more stable themes, lighter, etc. But oh well, we already agreed on that :D
I don't want to do that until #568 makes it into master, because doing so will make the @import trick in custom CSS not valid anymore, so users couldn't reliably change their themes at all.
|
#359 and no need to fix it ;) |
| @@ -587,11 +587,8 @@ button { | |||
| } | |||
|
|
|||
| #main { | |||
| background: #fff; | |||
There was a problem hiding this comment.
Because each window is taking care of its own background-color. And as far as I remember, it's necessary to remove this because of the radius being moved to .window instead of #main (letting us get rid of that ugly, half-working overflow: hidden.
Does that make more sense now?
There was a problem hiding this comment.
In short, this is always shadowed by this.
…-again Move border-radius from #main to .window elements to fix radius once and for all
#537 only fixed it on chat windows,
but for some browser-specific display bug/reason not on settings, login, ...
No screenshot here, it's literally the same bug than #537 but applied to all windows.