Disable tooltips on mobile to prevent them to stay after clicking #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
Type: Bug
astorije
force-pushed
the
astorije/585-fix-tooltips
branch
from
8950554 to
87dfe2c
Compare
|
Fine by me for now, not that I think the tooltips are particularly useful. This might catch browsers as well on small screens in combination with zoom, but the fixed annoyance outweights the benefits for me. 👍 |
maxpoulin64
approved these changes
Sep 16, 2016
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…tips Disable tooltips on mobile to prevent them to stay after clicking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #585. Yeah, I know, this is less than ideal. But this is somewhat blocking 2.0.0 release. And none of the other options are ideal either (some discussed options will simply not work).
On v1.5.0, these buttons didn't have any tooltips, so they won't be missed on mobile. Plus any hovering effect on mobile is kind of a lost battle anyway.
We have an open issue on Primer's tooltips: primer/primer-tooltips#4
I suggest we hide them on mobile to freely deploy 2.0.0, and see to work them back in when we have a better solution.