Fix how highlights are handled

[xPaw]

• Partially fixes Actions containing Highlights display incorrectly #90 where highlighted actions were broken
• Sent actions are correctly identified as self
• Sent actions are correctly highlighted (previously this only worked when reloading from history)
• Minor performance improvement where received messages are no longer split twice

[maxpoulin64]

This one seems to break notifications on highlight. I put my test instance on a random channel and highlighted myself, but I didn't get the desktop notification and the badge didn't turn white either. It just displayed as if it was any other non-highlight channel message.

I also noticed the line doesn't get colored at all, so it's not clear it's a highlight. It just stays orange.

Did I miss something? I did run npm run build before and cleared the browser cache.

[xPaw]

Was there a .highlight class applied? Was it an action?

[maxpoulin64]

Yes, the .highlight class gets applied properly. But with both actions and regular messages, no desktop notification gets received, and the badge doesn't turn white. With regular messages, the line does turn red as expected however.

<div class="msg message highlight">
    <span class="time">
        03:49
    </span>
    <span class="from">
        <a href="#" class="user" style="color: #ff514d">Max-P_test</a>
    </span>
    <span class="text">
            Max-P: That still works
    </span>
</div>

<div class="msg action highlight">
    <span class="time">
        03:48
    </span>
    <span class="from"></span>
    <span class="text">
        <a href="#" class="user">Max-P_test</a>

         highlights Max-P
    </span>
</div>

Switching back to master, it all works again.

[xPaw]

This PR doesn't fix color on highlight (the other PR does), so that's fine. Unsure about notification though.

[maxpoulin64]

Found it: highlight checked here and broken here

Since you're adding an highlight property it should be an easy fix actually.

[xPaw]

Template adds the highlight class though, so that doesn't make sense.

[maxpoulin64]

It's not checking the class, it's checking the message type directly from the server event.

[xPaw]

Ah, my bad.

[xPaw]

@maxpoulin64 Should be fixed now.

[maxpoulin64]

I confirm it works fine for me now, 👍

[astorije]

👍