Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent highlights in query windows #333

Closed
xPaw opened this issue May 14, 2016 · 0 comments
Closed

Inconsistent highlights in query windows #333

xPaw opened this issue May 14, 2016 · 0 comments
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Milestone

Comments

@xPaw
Copy link
Member

xPaw commented May 14, 2016

When I fixed highlights to be handled on the server, it somewhat broke the query window behaviour.

Currently it acts as if it were a channel (only nick mentions highlight), but also highlight the first message when the window is created.

I think easiest solution would be to set highlight on all incoming message if they arent self, and then don't apply highlight class on the client in query windows. This approach would also remove highlights on your nick since that's a bit useless in query windows.

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label May 14, 2016
@xPaw xPaw added this to the ★ Next Release milestone May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

No branches or pull requests

1 participant