Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mate desktop icon names inactive highlight color wrong (invisible) #72

Open
geckolinux opened this issue Jul 14, 2020 · 6 comments
Open

Comments

@geckolinux
Copy link

Hi, I'm using a custom oomox theme with Mate 1.24 on openSUSE Tumbleweed. Here's my
gtk-3.20/dist/gtk.css file.

A problem I'm having is with the desktop icons, which become invisible when they are selected and then I focus on another window. For example, this is what I saw when trying to drag'n'drop the above CSS file into this issue editor:

Screenshot at 2020-07-14 07-48-57

Here's how highlighted text in an unfocused application normally looks (Simple Scan is focused):

Screenshot at 2020-07-14 07-53-23

I wonder how to change that without changing the main color of all the other applications? The color is #F7F7F7, and it appears all over the place, including in .gtkstyle-fallback.

Also, is this possibly related to #71 ?

@actionless
Copy link
Member

actionless commented Jul 14, 2020

I wonder how to change that without changing the main color of all the other applications?

use app-specific css selector, see in gtk inspector tree, usually it's the top one, or second from top, smth like MateDesktop

so final SCSS selector would be like

MateDesktop {
   .gtkstyle-fallback {
          foo: bar
    }
}

see https://github.com/themix-project/oomox-gtk-theme/blob/master/src/gtk-3.20/scss/apps/_mate-applications.scss

please send back the PR if you'll fix it on your side

Also, is this possibly related to #71 ?

not likely, but who knows

@geckolinux
Copy link
Author

geckolinux commented Aug 5, 2020

I finally found a fix that works in ~/.config/gtk-3.0/gtk.css

/* Fix Mate desktop selected icon background when unfocused */
.caja-desktop:selected {
background: #E95420;
}

Screenshot at 2020-08-05 10-47-07

Could this be integrated into the oomox generator for the global GTK theme?

I also tried background: @theme_bg_color; but it did not work, produced the same unreadable gray-on-gray that I posted in the original screenshot.

Thanks!

@actionless
Copy link
Member

because in your theme theme_bg_color is gray, try selected_bg_color: https://github.com/themix-project/oomox-gtk-theme/blob/master/src/gtk-3.20/scss/_global.scss#L14

@actionless
Copy link
Member

but to make those variables work, you'll need to edit https://github.com/themix-project/oomox-gtk-theme/blob/master/src/gtk-3.20/scss/apps/_mate-applications.scss as i mentioned above

@geckolinux
Copy link
Author

@actionless Thanks for the reply. And how do I "compile" it after adjusting the .scss? (Sorry I don't know what the proper term is.)

@actionless
Copy link
Member

just generate theme as normally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants