avoid sending "apikey" parameter if "apikey==0" #427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viders that don't require an api key (and error out if provided)
|
Huh, that's weird. Which indexers don't use API keys? |
|
Hey, thanks for the PR but I decided to go a slightly different way. |
theotherp
pushed a commit
that referenced
this pull request
Nov 26, 2016
|
sound great, thanks @theotherp, looking forward to the merge to master branch! |
|
It's in there now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it may not be the most elegant solution and perhaps a comment needs to be added on the configuration page to explain it, but there are a few newznab providers that don't need an api key and that will actually error out if the parameter is provided.