IPv6-compatability, specifically for Secure IP Ranges #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey. Thanks a lot! I'll check it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
as Secure IP Ranges doesnt support IPv6, i added some support around the code where i could find.
Secure IP Ranges now supports IPv6-Adresses, ranges and IPv4 + IPv6 CIDR notation.
I have also improved some checks using spring security's IpAddressMatcher.
Validation-regex is a bit simplified as i didnt want a huge regex to detect all possible IPv6 spelling types.
No idea what nzbhydra.js.map is.. but i modified the description Text of the function there too.
I am not sure how to run or compile the project, so you should check if it actually works as intended.
Feel free to pick and choose what you need, i am happy as long as Secure IP Ranges gets at least wildcard-support.