Performance: Precompile the ImmutableComponentTrait::encode() regex #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pattern is used in several places:
This regex is being recalculated and rebuilt every time ImmutableComponentTrait::encode(), Path::validate(), or HierarchicalPath::validate() is being called. Believe it or not, compiling this regex accounts for ~50% of the time spent in this benchmark. This PR compiles the entire regex 1x per implementor of ImmutableComponentTrait. A blackfire run of that benchmark script will show anywhere from a 40-60% reduction in time spent running that script (
blackfire run --samples=5 php perf.php
). So basically, we get a huge speed boost with no downside that I can see.