Performance: Avoid using sameValueAs() when setting properties in ImmutablePropertyTrait #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perty values in ImmutablePropertyTrait
nyamsprod
added a commit
that referenced
this pull request
Dec 28, 2015
Performance: Avoid using sameValueAs() when setting properties in ImmutablePropertyTrait
nyamsprod
added a commit
that referenced
this pull request
Nov 17, 2022
Performance: Avoid using sameValueAs() when setting properties in ImmutablePropertyTrait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the value of any property of a URL ends up triggering a call to ImmutablePropertyTrait::withProperty(). Inside this method, there's a call to UriPart::sameValueAs(), which ends up cascading a lot of calls down to other methods. What about just using a direct object comparison instead?
In this benchmark, this improves performance 10-20% (as measured by
blackfire run --samples=5 php perf.php).