You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At present, oxmol is a bare wrapper over molecule.rs. There should be a Python component to the wrapper, for three primary reasons:
it will be much neater to handle errors on the Python side than on the Rust side, where to declare new error types we need to handle the GIL.
The .so file generated with PyO3 doesn't provide us with a real package - we have a module which contains modules. This generates strange errors when trying to run e.g. import oxmol.spec.
oxmol should eventually be listed on PyPI, and this is easier where we have the directory structure of a Python project
The text was updated successfully, but these errors were encountered:
thesketh
changed the title
We need a Python component to the oxmol wrapper
There should be a Python component to the oxmol wrapper
May 22, 2020
This is complicated by the fact that it's not possible to properly subclass the PyO3 classes, I'm unable to catch the errors from within Python. The error handling will have to be improved on the Rust side.
This has been fixed by introducing the Python wrapper (and using Maturin for the build process)
At present, oxmol is a bare wrapper over
molecule.rs
. There should be a Python component to the wrapper, for three primary reasons:so
file generated with PyO3 doesn't provide us with a real package - we have a module which contains modules. This generates strange errors when trying to run e.g.import oxmol.spec
.The text was updated successfully, but these errors were encountered: