Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] testbench support for IPC4 #1177

Open
lgirdwood opened this issue Apr 19, 2024 · 5 comments
Open

[FEATURE] testbench support for IPC4 #1177

lgirdwood opened this issue Apr 19, 2024 · 5 comments
Labels
P1 Blocker bugs or important features type:test coverage gap This requires a new test case, not just fixing one

Comments

@lgirdwood
Copy link
Member

Testbench can be built with support for ipc3 or ipc4, but not both. Testbench needs current tests to target IPC3 build only to allow upstreaming of ipc4 testbench (which can then reuse existing tests with changes for ipc4).
@singalsu @ranj063 fyi.
@marc-hb this is needed for v2.10, I think you may also need to help with all the cmake changes to build both flavours of testbench too. Thanks !

@lgirdwood lgirdwood added the P1 Blocker bugs or important features label Apr 19, 2024
@marc-hb
Copy link
Collaborator

marc-hb commented Apr 19, 2024

I searched email and found this:

@marc-hb marc-hb added the type:test coverage gap This requires a new test case, not just fixing one label Apr 19, 2024
@marc-hb
Copy link
Collaborator

marc-hb commented Apr 19, 2024

Testbench can be built with support for ipc3 or ipc4, but not both.

Just like any other Kconfig? Or am I missing something?

To build different Kconfigs then just build twice as usual.

Testbench needs current tests to target IPC3 build only to allow upstreaming of ipc4 testbench (which can then reuse existing tests with changes for ipc4).

I spent a fairly large number of minutes trying to understand this and... I failed. AFAIK the IPC type is a build-time decision so I don't understand how tests can "target" one IPC type in particular. I admit I never used the testbench.

I think you may also need to help with all the cmake changes to build both flavours of testbench too.

I had a look at thesofproject/sof#9025 but there is very little CMake changes and there is a [DO NOT REVIEW] label for now.

BTW: this has nothing to do with sof-test but I guess it's more convenient to have all "coverage gaps" in the same place.

@singalsu
Copy link
Contributor

This needs to wait for #9025 to restore IPC3 testbench features (removed in current draft). There should be build for testbench3 and testbench4 and update to sof-test to run both.

@marc-hb
Copy link
Collaborator

marc-hb commented Apr 22, 2024

BTW: this has nothing to do with sof-test but I guess it's more convenient to have all "coverage gaps" in the same place.

update to sof-test to run both.

I don't think sof-test runs the testbench or that it ever has been? AFAIK there is only some github action compiling it with the Zephyr SDK. Is there anything else?

@singalsu
Copy link
Contributor

There's scripts/host-testbench.sh run, yep it's not from sof-test but some action.

@marc-hb marc-hb removed their assignment Aug 7, 2024
@marc-hb marc-hb changed the title [FEATURE] Support for different testbench builds with IPC3/4 [FEATURE] testbench support for IPC4 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Blocker bugs or important features type:test coverage gap This requires a new test case, not just fixing one
Projects
None yet
Development

No branches or pull requests

3 participants