From 3c4184b1a44ce59cbf6bc507c6891cbaa9c76aad Mon Sep 17 00:00:00 2001 From: Andy Ross Date: Tue, 17 Dec 2024 16:48:19 -0800 Subject: [PATCH] math: Fix dependencies in filter HiFi selection The intent of the dependencies on this choice seems to be that they apply only to certain components so the selection should be hidden if they aren't in use. But the logic was wrong: instead of enabling it if any component was enabled that needed it, it would hide the selection unless ALL such components were enabled. Which doesn't build. Fix. (Also I note the comment implies that other kconfigs should probably be in the list too, but not adding them out of conservatism as this is, again, just a hygiene thing.) Signed-off-by: Andy Ross --- src/math/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/math/Kconfig b/src/math/Kconfig index 08e4f9a554f0..ccd7520f20a7 100644 --- a/src/math/Kconfig +++ b/src/math/Kconfig @@ -128,9 +128,7 @@ endmenu # this choice covers math iir, math fir, tdfb, and eqfir, eqiir. choice "FILTER_SIMD_LEVEL_SELECT" prompt "choose which SIMD level used for IIR/FIR/TDFB module" - depends on COMP_FIR - depends on COMP_IIR - depends on COMP_TDFB + depends on COMP_FIR || COMP_IIR || COMP_TDFB default FILTER_HIFI_MAX config FILTER_HIFI_MAX