You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Another problem I've noticed running git on windows locally is that git for windows by default does not create symlinks, causing some of the test cases to fail where test case metadata files are de-duplicated through links. Github workflows seems to enable core.symlinks so this shouldn't be a problem for the CI, but may be for users. Should we remove the symlinks or just leave it as-is?
Good find. I think we can address this later; I'll file an issue. The symlinks are all consistent snapshot-related so I think they're somewhat deliberate.
TBH I'd prefer to keep the symlinks and fix this with documentation. If we must remove them, we'd need some automation around making sure the files stay in sync.
Thanks to @torin-carey for catching this!
Good find. I think we can address this later; I'll file an issue. The symlinks are all consistent snapshot-related so I think they're somewhat deliberate.
TBH I'd prefer to keep the symlinks and fix this with documentation. If we must remove them, we'd need some automation around making sure the files stay in sync.
Originally posted by @znewman01 in #274 (comment)
The text was updated successfully, but these errors were encountered: