Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests rely on symlinked files in testdata, which don't work in Windows by default #313

Closed
znewman01 opened this issue Jun 9, 2022 · 1 comment

Comments

@znewman01
Copy link
Contributor

Thanks to @torin-carey for catching this!

Another problem I've noticed running git on windows locally is that git for windows by default does not create symlinks, causing some of the test cases to fail where test case metadata files are de-duplicated through links. Github workflows seems to enable core.symlinks so this shouldn't be a problem for the CI, but may be for users. Should we remove the symlinks or just leave it as-is?

Good find. I think we can address this later; I'll file an issue. The symlinks are all consistent snapshot-related so I think they're somewhat deliberate.

TBH I'd prefer to keep the symlinks and fix this with documentation. If we must remove them, we'd need some automation around making sure the files stay in sync.

Originally posted by @znewman01 in #274 (comment)

@rdimitrov
Copy link
Contributor

Closing since the code base changed and we are no longer using the same tests.

Thanks for raising this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants