Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linters are not running for Go 1.18 #362

Closed
ethan-lowman-dd opened this issue Aug 24, 2022 · 3 comments · Fixed by #364
Closed

Linters are not running for Go 1.18 #362

ethan-lowman-dd opened this issue Aug 24, 2022 · 3 comments · Fixed by #364

Comments

@ethan-lowman-dd
Copy link
Contributor

See example: https://github.com/theupdateframework/go-tuf/runs/8000187792?check_suite_focus=true

level=warning msg="[linters context] gosimple is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=warning msg="[linters context] staticcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=warning msg="[linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=warning msg="[linters context] unused is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."

golangci/golangci-lint#2649

@trishankatdatadog
Copy link
Member

What's a good fix?

@asraa
Copy link
Contributor

asraa commented Aug 24, 2022

Since we aren't using generics (which I believe is the issue), we can fallback on running with go 1.17

@ethan-lowman-dd
Copy link
Contributor Author

I can submit a patch, I think it's quick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants