Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please build releases for darwin_arm64 #461

Closed
udf2457 opened this issue Feb 22, 2023 · 3 comments
Closed

Please build releases for darwin_arm64 #461

udf2457 opened this issue Feb 22, 2023 · 3 comments
Assignees
Labels
github_actions Pull requests that update GitHub Actions code release

Comments

@udf2457
Copy link
Contributor

udf2457 commented Feb 22, 2023

At present you are only building releases for darwin_amd64.

With the increasing prevalence of Apple Silicon based systems, you should really start to also build for darwin_arm64

@trishankatdatadog
Copy link
Member

Sounds like a good idea. Do you think you could help us with this, perhaps by updating our GitHub workflows? Not sure if it's possible, but needs investigation. Thanks!

@trishankatdatadog trishankatdatadog added github_actions Pull requests that update GitHub Actions code release labels Feb 22, 2023
@udf2457
Copy link
Contributor Author

udf2457 commented Feb 22, 2023

@trishankatdatadog I'm no goreleaser expert, but I'm guessing it might be as simple as adding arm64 to .goreleaser/tuf.yml which currenltly only has amd64 in it ?

Certainly I know on the CLI its as simple as passing the right GOARCH to go build. So its likely just a question of where the same thing goes in a CI/CD process.

@trishankatdatadog
Copy link
Member

@trishankatdatadog I'm no goreleaser expert, but I'm guessing it might be as simple as adding arm64 to .goreleaser/tuf.yml which currenltly only has amd64 in it ?

Great, so please help us send a PR to test it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code release
Projects
None yet
Development

No branches or pull requests

3 participants