Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Consider further caching in CI workflow #1247

Open
lukpueh opened this issue Dec 17, 2020 · 5 comments
Open

GitHub Actions: Consider further caching in CI workflow #1247

lukpueh opened this issue Dec 17, 2020 · 5 comments
Labels
github_actions Pull requests that update GitHub Actions code good first issue Bite-sized items for first time contributors

Comments

@lukpueh
Copy link
Member

lukpueh commented Dec 17, 2020

Description of issue or feature request:
#1242 added a GitHub Actions based CI workflow, which configures basic pip caching.

Current behavior:
Basic pip caching in CI workflow

Expected behavior:
Explore and implement further caching to further speed up CI workflow (@jku suggests to try caching the tox directory).

@lukpueh
Copy link
Member Author

lukpueh commented Jan 15, 2021

Also cache pip install in non-"test" jobs, e.g. "coveralls-fin" introduced in #1252. It would be nice to find a cross-job caching solution.

@jku
Copy link
Member

jku commented Jan 15, 2021

Leaving a note for later: Defining an action of our own in this same repo should allow using the same code across different jobs: Maybe it's not hard to define a "pip-install" action that sets up cache, updates pip and installs/updates the given list of packages.

@jku
Copy link
Member

jku commented Dec 16, 2021

cache pip install in non-"test" jobs, e.g. "coveralls-fin" introduced in #1252

this one might be the only relevant thing left here as

  • caching tox is not a good idea: tox is not able to handle some changes in dependencies, so we'd need to build something ourselves... not worth it
  • setup-python now handles cache (CI: Use builtin package cache support #1718) so that's not longer ugly

@lukpueh lukpueh added the good first issue Bite-sized items for first time contributors label Mar 16, 2022
@ivanayov ivanayov added the github_actions Pull requests that update GitHub Actions code label Apr 20, 2022
@h4l0gen
Copy link
Contributor

h4l0gen commented May 25, 2024

Hi @jku @lukpueh, If this issue is available to take on, I would like to work on it.

@jku
Copy link
Member

jku commented May 27, 2024

this issue is old... There may be caching opportunities in the workflows but there is no check-list to go through, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code good first issue Bite-sized items for first time contributors
Projects
None yet
Development

No branches or pull requests

4 participants