Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prediction is triggered too early during demo on Firefox #18

Open
thiborose opened this issue Dec 30, 2020 · 2 comments
Open

Prediction is triggered too early during demo on Firefox #18

thiborose opened this issue Dec 30, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@thiborose
Copy link
Owner

thiborose commented Dec 30, 2020

When a demo is launched, on the longest sentences, the prediction is triggered before the sentence is completely filled in the input box. This causes the output to be corrupted.

Issue occuring on Firefox. Not occuring on: Brave, Chrome, Chromium, Edge.

File involved: https://github.com/psawa/gecko-app/blob/master/application/static/js/demo.js

@thiborose thiborose added bug Something isn't working high priority labels Dec 30, 2020
@thiborose
Copy link
Owner Author

Similarly, I noticed that in chrome, if the browser is focused on another tab, the demo animation will halt. Then the prediction will be triggered before the input sentence is complete.

@jacqle
Copy link
Collaborator

jacqle commented Jan 9, 2021

When a demo is launched, on the longest sentences, the prediction is triggered before the sentence is completely filled in the input box. This causes the output to be corrupted.

I don't have this issue on Firefox.

Similarly, I noticed that in chrome, if the browser is focused on another tab, the demo animation will halt. Then the prediction will be triggered before the input sentence is complete.

Happens on Firefox too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants