Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate files #33

Open
kristho91 opened this issue Nov 16, 2019 · 1 comment
Open

Duplicate files #33

kristho91 opened this issue Nov 16, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@kristho91
Copy link
Contributor

There are some duplicate files present, I'm not sure which ones are in use.

"tools/*" exists both in root-folder and in "js/"-folder.
"advanced-payment-api.js" exists both in root-folder and in "js/"-folder.

I think we should keep the copies in "js/"-folder. But I'm unsure if the other copies are referenced somewhere.
@Traumflug
Copy link
Contributor

Such duplicate files often exist for retrocompatibility with older versions. Less for compatibility with PrestaShop, more for compatibility with PS modules.

Accordingly, an investigation should look up when PS moved these files. If it's PS 1.4 or earlier, removing them is a good idea.

@getdatakick getdatakick added the enhancement New feature or request label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Traumflug @kristho91 @getdatakick