Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise support #43

Open
zeke opened this issue Jul 30, 2019 · 3 comments
Open

Promise support #43

zeke opened this issue Jul 30, 2019 · 3 comments

Comments

@zeke
Copy link

zeke commented Jul 30, 2019

Hello @thisandagain! Long time no see. 👋

This module is handy, but it would be more ergonomic in our new async/await world if it supported Promises. I'd be happy to open a PR for this but want to see first if this module is maintained, and if such a change would be welcomed.

@thisandagain
Copy link
Owner

Hey @zeke! 👋

This module is still used in production by our team, but I haven't had much reason to make changes. Happy to accept a PR adding support for promises.

@zeke
Copy link
Author

zeke commented Jul 31, 2019

Nice! Question: Would you be open to a new major version (breaking change) that only supports Promises? Or is it important to continue supporting both?

@thisandagain
Copy link
Owner

It would be ideal to support both, but I'm certainly open to a major version bump that only supports promises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants