Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect rendering of X and O #4

Open
0xDEADC0DER opened this issue Jan 3, 2024 · 3 comments
Open

Incorrect rendering of X and O #4

0xDEADC0DER opened this issue Jan 3, 2024 · 3 comments

Comments

@0xDEADC0DER
Copy link
Contributor

The hardcoded X and O ASCII arts don't render properly on terminals having large font size.

@thomas-mauran
Copy link
Owner

Yeah, having the same issue on chess-tui and to fix that you need to manualy zoom in or out of your terminal using ctrl + / - for the moment it is the only effective way to adjust the pieces size

@0xDEADC0DER
Copy link
Contributor Author

I think using the Canvas widget might help.
The widget allows you to draw arbitrary shapes on the terminal.
Perfect for drawing diagonal lines and circles which are the required shapes for the game.
I am learning ratatui myself, maybe some time later I'll make a PR fixing this problem.

Same goes for chess-tui

@thomas-mauran
Copy link
Owner

Good idea, if you wanna make a pr go ahead !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants