-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a pre-commit hook for the Thoth adviser #233
Comments
/triage accepted thanks for the issue, we had some discussion regarding this |
/assign @mayaCostantini |
@TomasTomecek a first release of the Thoth pre-commit hook is available at https://github.com/thoth-station/thoth-pre-commit-hook |
wow, that's awesome, thank you! we have also prioritized recently the task to use thoth, will add the link to the pre-commit hook there |
that is great news! 🎉 |
@mayaCostantini in the |
@erikerlandson Right, thanks for pointing it out. I will add more documentation on thamos arguments 👍 |
Let's close this issue as the pre-commit hook is now available at https://github.com/thoth-station/thoth-pre-commit-hook |
Is your feature request related to a problem? Please describe.
I can run Thoth using pre-commit both locally and in CI via the same workflow. GHA only provides the CI part.
High-level Goals
Teams can add Thoth pre-commit hook in their
.pre-commit-config.yaml
.Describe the solution you'd like
Provide a pre-commit hook that can run Thoth on GitHub PRs, and especially run it locally.
Describe alternatives you've considered
GHA is a solid alternative.
Additional context
∅
Acceptance Criteria
See goals above.
8 story points :P
The text was updated successfully, but these errors were encountered: