Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a pre-commit hook for the Thoth adviser #233

Closed
TomasTomecek opened this issue Jun 9, 2022 · 8 comments
Closed

Provide a pre-commit hook for the Thoth adviser #233

TomasTomecek opened this issue Jun 9, 2022 · 8 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@TomasTomecek
Copy link

Is your feature request related to a problem? Please describe.
I can run Thoth using pre-commit both locally and in CI via the same workflow. GHA only provides the CI part.

High-level Goals
Teams can add Thoth pre-commit hook in their .pre-commit-config.yaml.

Describe the solution you'd like
Provide a pre-commit hook that can run Thoth on GitHub PRs, and especially run it locally.

Describe alternatives you've considered
GHA is a solid alternative.

Additional context

Acceptance Criteria
See goals above.

8 story points :P

@TomasTomecek TomasTomecek added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 9, 2022
@sesheta sesheta added needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. needs-sig labels Jun 9, 2022
@harshad16
Copy link
Member

/triage accepted
/sig stack-guidance

thanks for the issue, we had some discussion regarding this
it's great to know users would like this.

@sesheta sesheta added triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. and removed needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. needs-sig labels Jun 9, 2022
@mayaCostantini
Copy link

/assign @mayaCostantini

@mayaCostantini
Copy link

@TomasTomecek a first release of the Thoth pre-commit hook is available at https://github.com/thoth-station/thoth-pre-commit-hook
Feedback and feature propositions are welcome!

@TomasTomecek
Copy link
Author

wow, that's awesome, thank you! we have also prioritized recently the task to use thoth, will add the link to the pre-commit hook there

@erikerlandson
Copy link

that is great news! 🎉

@erikerlandson
Copy link

@mayaCostantini in the thoth advise usage statement I don't see what the options are for --recommendation-type

@mayaCostantini
Copy link

@erikerlandson Right, thanks for pointing it out. I will add more documentation on thamos arguments 👍

@mayaCostantini
Copy link

Let's close this issue as the pre-commit hook is now available at https://github.com/thoth-station/thoth-pre-commit-hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants