Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code splitted sourcemaps not uploaded, despite being emitted by webpack #27

Closed
oller opened this issue Dec 22, 2016 · 3 comments · Fixed by #28
Closed

Code splitted sourcemaps not uploaded, despite being emitted by webpack #27

oller opened this issue Dec 22, 2016 · 3 comments · Fixed by #28
Labels

Comments

@oller
Copy link

oller commented Dec 22, 2016

Hi there, this plugin has saved me a lot of shell script headaches, thank you!

I'm having trouble getting the plugin to upload all sourcemaps. In my instance, it detects and correctly uploads:

  • main.[hash].js
  • vendor.[hash].js

Both of which are specified in the entry object.

However webpack is also generating n chunks for me based on require.ensure code splitting for the modules within the app. For this particular app, n = 0 through to 4, so 5 additional chunks.

  • n.[hash].js

I can see these emitted by webpack and written to my dist dir.

My config:

        new RollbarSourceMapPlugin({
            accessToken: "******",  // RollBar post_server_item
            version: childProcess.execSync("git rev-parse HEAD").toString(),  // Get hash of last commit
            publicPath: "http://example.com"
        })

The docs states if includeChunks as an option is omitted, all webpack emitted sourcemap files will be uploaded, however this doesn't seem to be the case. Any tips?

Thanks! 🎄 🎅 🎄

@brandondoran
Copy link
Collaborator

Hi @oller,
Great to hear this has been useful for you!

It looks like this is indeed a bug. For our dymanic/route chunks we're giving them names rather than ids so this is probably why we haven't run into this. But yes, the intent is that it should work for your use case. I'll look into a fix for this.

Thanks for submitting the issue!

@oller
Copy link
Author

oller commented Jan 3, 2017

Thanks @brandondoran, that's right - I'm not explicitly naming these chunks at all, just letting webpack deal with them as it builds the app, so it'll be following whatever webpack's default naming convention / behaviour is for hitting split points.

Let me know if there's anything I can do to help.

Thanks!

@oller
Copy link
Author

oller commented Jan 10, 2017

Looks good to me 👍

I'll test again once it's merged into master and released. Thanks again for the great plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants