Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Scaled" to the "Default Sort" setting #1002

Closed
K4LCIFER opened this issue Dec 23, 2023 · 6 comments
Closed

Add "Scaled" to the "Default Sort" setting #1002

K4LCIFER opened this issue Dec 23, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version

Comments

@K4LCIFER
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The default sort type setting does not contained the option for "scaled"
Screenshot_20231222-160236

Describe the solution you'd like
Add the "Scaled" sort-type to the default sort type option.

Describe alternatives you've considered
None.

Additional context
None.

@K4LCIFER K4LCIFER added the enhancement New feature or request label Dec 23, 2023
@micahmo
Copy link
Member

micahmo commented Dec 23, 2023

Previous discussion for reference! Thanks!

#829 (comment)

@hjiangsu
Copy link
Member

hjiangsu commented Jan 8, 2024

I'll just add this in here: https://fedidb.org/software/lemmy

I believe we should wait a bit longer until the majority of instances have migrated to 0.19.x before adding the new sorts as options. Once the top 30~40 instances have migrated to 0.19.x, we can enable these options in the settings. This should cover the majority of users.

@K4LCIFER
Copy link
Contributor Author

K4LCIFER commented Jan 8, 2024

I'll just add this in here: https://fedidb.org/software/lemmy

I believe we should wait a bit longer until the majority of instances have migrated to 0.19.x before adding the new sorts as options. Once the top 30~40 instances have migrated to 0.19.x, we can enable these options in the settings. This should cover the majority of users.

Would it be worth it to just have Thunder check what version the server is running, or check if the server offers a scaled sort, and then dynamically change the UI depending on what the server offers?

@hjiangsu
Copy link
Member

hjiangsu commented Jan 8, 2024

Would it be worth it to just have Thunder check what version the server is running, or check if the server offers a scaled sort, and then dynamically change the UI depending on what the server offers?

The one issue here is that the sort type is global across all instances/servers, and it is not synced per account. This means that if a user chooses one of the new sort types, there should be a secondary option to fallback to if the instance does not support the new sort type. Doing this would take a bit more work on our part and it would be a short term solution (that would be removed once most instances have migrated to 0.19.x)

I believe the better approach here (and feel free to let me know if you think otherwise) is to make it so that the default sort type is synced with your account (Lemmy) settings since that is already part of Lemmy itself. Then, we could re-use the existing sort type setting to be used for anonymous (non-logged in) accounts.

@orangeNgreen
Copy link

Now that most instances have upgraded to 0.19.x, it might be a good time to implement Scaled sort as a default setting.

@daviessm
Copy link

Yeah, I think that now 0.3.0 is out this is a good candidate for the next release.

@micahmo micahmo self-assigned this Apr 11, 2024
@micahmo micahmo added in-progress Indicates that an issue is currently being worked on fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version and removed in-progress Indicates that an issue is currently being worked on labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

5 participants