Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts replace entire screen with error message #134

Closed
thepaperpilot opened this issue Jun 28, 2023 · 2 comments
Closed

Timeouts replace entire screen with error message #134

thepaperpilot opened this issue Jun 28, 2023 · 2 comments
Assignees
Labels
bug Something isn't working fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version

Comments

@thepaperpilot
Copy link

thepaperpilot commented Jun 28, 2023

Description
Some servers are a bit overloaded and will time out on requests to upvote comments and posts. When that happens not only do you get a toast notifying you, but the whole screen gets replaced with the error as well, and you have to go to a previous page or refresh to fix it.

How to Reproduce
Steps to reproduce the behavior:

  1. Go to beehaw.org or other server that has regular timeouts
  2. Upvote comments until you get a timeout
  3. Get the following toast and error page seen in the screenshots section

Expected Behavior
Keep the toast, revert the upvote, and let me continue reading the comments and try upvoting again

Screenshots
If applicable, add screenshots to help explain your problem.

Screenshot_2023-06-28-11-05-25-59_ab870a90287380db09018f87a3131b61

Device & App Version:

  • Device: Android OnePlus 9
  • OS: OxygenOS 13
  • Version: 0.2.1+8
@thepaperpilot thepaperpilot added the bug Something isn't working label Jun 28, 2023
@hjiangsu
Copy link
Member

hjiangsu commented Jul 1, 2023

I think this should be fixed in the upcoming release - it'll only show the full screen error if there is an issue with fetching the post itself rather than comments

@hjiangsu hjiangsu added the fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version label Jul 1, 2023
@hjiangsu hjiangsu self-assigned this Jul 1, 2023
@hjiangsu
Copy link
Member

hjiangsu commented Jul 2, 2023

Closing as this should be fixed in v0.2.1+10!

@hjiangsu hjiangsu closed this as completed Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

2 participants