Issues present after testing:

• Banning user from community does not work as intended (fixed)

Note: I've opted to keep remove the ability to set the "expiry" date on banned users because I was not able to get the automatic unban to work (need to dig further to see how the automatic unban feature works for Lemmy)

As this is a relatively large change, I'll be merging this in to allow some time for internal/dev testing. Let me know if you notice any issues! @micahmo 😄

Looks great just from the screenshots! 😊 I'll definitely take some time to play around with it. I might also have to fix some conflicts in some my pending PRs. 😊

Thanks! I also wanted to say sorry for the delay in reviewing the other PRs, I'll definitely try to speed those up to reduce further conflicts if possible!

No problem at all, I know things have been busy! I've slowed down my contributions as well so as to not overwhelm you. I know reviewing can be one of the most tedious parts of managing an open source project. If/when some of those other PRs get cleaned up, I'd be happy to jump back in and continue contributing! Especially as a new version of Lemmy is coming down the pipe. 😊

@hjiangsu I've noticed a couple things so far.

1. It looks like, to navigate back from a bottom sheet subpage, you can now only click the back icon, as opposed to the whole header. I'm sure this change was intentional, but I just wanted to bring it up as it's not only changing existing behavior, but now also makes the post bottom sheets behave differently than other bottom sheets throughout the app (like comments).
2. There are also other minor visual differences between the post bottom sheet and other bottom sheets in the app, like how each action item has a bolded title now. To me it looks a little too bold, but I'm probably just used to the way it used to be.
3. The share button within the post viewer is supposed to jump directly to the share subpage of the post bottom sheet, but it now just brings up the main page (so you have to click again to share).

Thanks for mentioning these issues!

It looks like, to navigate back from a bottom sheet subpage, you can now only click the back icon, as opposed to the whole header. I'm sure this change was intentional, but I just wanted to bring it up as it's not only changing existing behavior, but now also makes the post bottom sheets behave differently than other bottom sheets throughout the app (like comments).

This was an intentional change - the intent being matching the behaviour of how app bars "back" buttons work. I do plan to overhaul the comments bottom sheet as well to match up with the behaviour of the post bottom sheet.

All that being said, I am open to reverting this behaviour back to the old behaviour if its undesired!

There are also other minor visual differences between the post bottom sheet and other bottom sheets in the app, like how each action item has a bolded title now. To me it looks a little too bold, but I'm probably just used to the way it used to be.

I can try to reduce the boldness of the action items to be less jarring - I mainly wanted a visual separation of the main action and the subtitles. As I mentioned above, I do plan to change the comment bottom sheet to match up visually with the new changes introduced here!

The share button within the post viewer is supposed to jump directly to the share subpage of the post bottom sheet, but it now just brings up the main page (so you have to click again to share).

Oops, that missed my testing, nice catch! 😅

I'm good with whatever direction you want to head; just keep in mind that all other bottom sheets throughout the app will need to be updated, not just comments. I'm not sure if you created new widgets for the action items, but I think existing sheets use PickerItem.